linux-kernel - Re: [PATCH V8 13/15] perf tools: expand perf_event__synthesize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130724131526.GD4203@krava.brq.redhat.com>
Date:	Wed, 24 Jul 2013 15:15:27 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	linux-kernel@...r.kernel.org, David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH V8 13/15] perf tools: expand
 perf_event__synthesize_sample()

On Wed, Jul 24, 2013 at 04:15:20PM +0300, Adrian Hunter wrote:

SNIP

> >> +	}
> >> +
> >> +	if (type & PERF_SAMPLE_REGS_USER) {
> >> +		if (sample->user_regs.regs && sample_regs_user) {
> >> +			*array++ = sample_regs_user;
> > 
> > it's 'enum perf_sample_regs_abi' value that goes here ^^^
> > 
> > I guess for now it could be hardcoded like:
> > 
> > #if defined(__x86_64__)
> > abi = PERF_SAMPLE_REGS_ABI_64
> > #else
> > #if defined(__i386__)
> > abi = PERF_SAMPLE_REGS_ABI_64

ugh, PERF_SAMPLE_REGS_ABI_32 ^^^ of course ;-)

> > #endif
> > WARN()
> > #endif
> 
> Thanks for reviewing this.
> 
> Why isn't it better to leave it as a parameter?

np, you could have it as parameter.. but I guess for now
you'll endup with above code in the upper layer anyway

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/