linux-kernel - Re: [PATCH v4] regulator: pfuze100: add pfuze100 regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130724143931.GJ9858@sirena.org.uk>
Date:	Wed, 24 Jul 2013 15:39:31 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Steffen Trumtrar <s.trumtrar@...gutronix.de>
Cc:	Robin Gong <b38343@...escale.com>, shawn.guo@...aro.org,
	grant.likely@...aro.org, rob.herring@...xeda.com, rob@...dley.net,
	lgirdwood@...il.com, devicetree-discuss@...ts.ozlabs.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] regulator: pfuze100: add pfuze100 regulator driver

On Wed, Jul 24, 2013 at 11:51:45AM +0200, Steffen Trumtrar wrote:
> On Wed, Jul 24, 2013 at 10:42:28AM +0100, Mark Brown wrote:

> > >  static struct regulator_ops pfuze100_fixed_regulator_ops = {
> > > 	.list_voltage = regulator_list_voltage_linear,
> > > +	.set_voltage_sel = regulator_set_voltage_sel_regmap,
> > >  };

> > This doesn't make much sense, you're adding a set voltage operation to a
> > fixed voltage regulator...

> Hm, okay, sounds reasonable. But if I don't, VREFDDR isn't registered because
> _regulator_do_set_voltage returns with -EINVAL.
> So, I probably just fixed a symptom and not the cause.

Yes, the obvious question is why we're trying to set a voltage on a
regulator which can't change voltage.  Usually this is a result of
setting a constraint that tries to force the voltage.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)