linux-kernel - Re: [REVIEW][PATCH] vfs: Lock in place mounts from more privileged users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130724153018.GA17960@mail.hallyn.com>
Date:	Wed, 24 Jul 2013 15:30:18 +0000
From:	"Serge E. Hallyn" <serge@...lyn.com>
To:	"Serge E. Hallyn" <serge@...lyn.com>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Andy Lutomirski <luto@...capital.net>,
	Linux Containers <containers@...ts.linux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [REVIEW][PATCH] vfs: Lock in place mounts from more privileged
 users

Quoting Serge E. Hallyn (serge@...lyn.com):
> Quoting Eric W. Biederman (ebiederm@...ssion.com):
> > 
> > Serge does this patch break lxc?  I think all should be well but I want
> > to make certain there is not some hidden case where this fundamentaly
> > breaks some functionality.
> 
> I haven't yet tried.  I'll build and test a kernel today.  I'm pretty
> sure all the child's mounts are done after clone, so I *think* the worst
> case will be that the unmounting of put_old after pivot_root() will
> be noisy.  Will let you know.
> 
> -serge

Just tested it - works fine.  Warns about all of the failed umounts.

Acked-by: Serge Hallyn <serge.hallyn@...onical.com>

( Mind you I'm not approving of the idea of hiding mounts as a security
mechanisms, but I know that neither are you :)

thanks,
-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/