linux-kernel - Re: [PATCH v3 3/3] Input: omap-keypad: Clear interrupts on open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130724160635.GG29384@radagast>
Date:	Wed, 24 Jul 2013 19:06:35 +0300
From:	Felipe Balbi <balbi@...com>
To:	Illia Smyrnov <illia.smyrnov@...com>
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Felipe Balbi <balbi@...com>, <linux-input@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>
Subject: Re: [PATCH v3 3/3] Input: omap-keypad: Clear interrupts on open

Hi,

On Wed, Jul 24, 2013 at 06:54:53PM +0300, Illia Smyrnov wrote:
> Clear interrupts when open keypad.
> 
> According to TRM, the recommended way for keyboard controller
> initialization is clear the interrupt-status register, then set up
> certain keyboard events for generating an interrupt request and
> set up expected source of wake-up event that generates a wake-up
> request.
> 
> Signed-off-by: Illia Smyrnov <illia.smyrnov@...com>
> ---
>  drivers/input/keyboard/omap4-keypad.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c
> index b876a0d..0244262 100644
> --- a/drivers/input/keyboard/omap4-keypad.c
> +++ b/drivers/input/keyboard/omap4-keypad.c
> @@ -185,8 +185,9 @@ static int omap4_keypad_open(struct input_dev *input)
>  			(OMAP4_VAL_PVT << OMAP4_DEF_CTRL_PTV_SHIFT));
>  	kbd_writel(keypad_data, OMAP4_KBD_DEBOUNCINGTIME,
>  			OMAP4_VAL_DEBOUNCINGTIME);
> +	/* clear pending interrupts */
>  	kbd_write_irqreg(keypad_data, OMAP4_KBD_IRQSTATUS,
> -			OMAP4_VAL_IRQDISABLE);
> +			 kbd_read_irqreg(keypad_data, OMAP4_KBD_IRQSTATUS));
>  	kbd_write_irqreg(keypad_data, OMAP4_KBD_IRQENABLE,
>  			OMAP4_DEF_IRQENABLE_EVENTEN |
>  				OMAP4_DEF_IRQENABLE_LONGKEY);

Reviewed-by: Felipe Balbi <balbi@...com>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)