linux-kernel - Re: [PATCH 5/6] tracing: Introduce remove_event_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1374696088.3356.156.camel@gandalf.local.home>
Date:	Wed, 24 Jul 2013 16:01:28 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Alexander Z Lam <azl@...gle.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	David Sharp <dhsharp@...gle.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Vaibhav Nagarnaik <vnagarnaik@...gle.com>,
	"zhangwei(Jovi)" <jovi.zhangwei@...wei.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] tracing: Introduce remove_event_file_dir()

On Tue, 2013-07-23 at 22:59 +0200, Oleg Nesterov wrote:

>  static void remove_event_from_tracers(struct ftrace_event_call *call)
>  {
>  	struct ftrace_event_file *file;
>  	struct trace_array *tr;
>  
>  	do_for_each_event_file_safe(tr, file) {
> -
> -		if (file->event_call != call)
> -			continue;
> -
> -		list_del(&file->list);
> -		debugfs_remove_recursive(file->dir);
> -		remove_subsystem(file->system);
> -		kmem_cache_free(file_cachep, file);
> -
> -		/*
> -		 * The do_for_each_event_file_safe() is
> -		 * a double loop. After finding the call for this
> -		 * trace_array, we use break to jump to the next
> -		 * trace_array.
> -		 */
> -		break;
> +		if (file->event_call == call) {

I don't care if you do it this way because it's just two lines, but the
reason I do the:

	if (file->event_call != call)
		continue;

is to keep the indentation down.

-- Steve

> +			remove_event_file_dir(file);
> +			/*
> +			 * The do_for_each_event_file_safe() is
> +			 * a double loop. After finding the call for this
> +			 * trace_array, we use break to jump to the next
> +			 * trace_array.
> +			 */
> +			break;
> +		}
>  	} while_for_each_event_file();
>  }
>  
> @@ -2298,12 +2300,8 @@ __trace_remove_event_dirs(struct trace_array *tr)
>  {
>  	struct ftrace_event_file *file, *next;
>  
> -	list_for_each_entry_safe(file, next, &tr->events, list) {
> -		list_del(&file->list);
> -		debugfs_remove_recursive(file->dir);
> -		remove_subsystem(file->system);
> -		kmem_cache_free(file_cachep, file);
> -	}
> +	list_for_each_entry_safe(file, next, &tr->events, list)
> +		remove_event_file_dir(file);
>  }
>  
>  static void


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/