linux-kernel - Re: [PATCH-RESEND 3/3] staging/lustre: fix Kconfig bool defaults

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130724200730.GA22161@kroah.com>
Date:	Wed, 24 Jul 2013 13:07:30 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Peng Tao <bergwolf@...il.com>
Cc:	linux-kernel@...r.kernel.org, Peng Tao <tao.peng@....com>,
	Andreas Dilger <andreas.dilger@...el.com>
Subject: Re: [PATCH-RESEND 3/3] staging/lustre: fix Kconfig bool defaults

On Thu, Jul 25, 2013 at 02:08:19AM +0800, Peng Tao wrote:
> From: Peng Tao <tao.peng@....com>
> 
> Should be y instead of true.
> 
> Reported-by: Paul Bolle <pebolle@...cali.nl>
> Cc: Andreas Dilger <andreas.dilger@...el.com>
> Signed-off-by: Peng Tao <tao.peng@....com>
> ---
>  drivers/staging/lustre/lustre/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
> index 9ae7fa8..e3b3c74 100644
> --- a/drivers/staging/lustre/lustre/Kconfig
> +++ b/drivers/staging/lustre/lustre/Kconfig
> @@ -52,4 +52,4 @@ config LUSTRE_DEBUG_EXPENSIVE_CHECK
>  config LUSTRE_TRANSLATE_ERRNOS
>  	bool
>  	depends on LUSTRE_FS && !X86
> -	default true
> +	default y

Why is the default for this going to be 'y'?  That should only be for
things that keep the machine from booting.

If this is something you always want to do, then why make it an option
at all?

Given that there is no documentation for what this option is, and why
people should always turn it on, I can't accept this patch, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/