linux-kernel - Re: [PATCH] ARM: Fix deadlock scenario with smp_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130724202148.GA24642@n2100.arm.linux.org.uk>
Date:	Wed, 24 Jul 2013 21:21:48 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: Fix deadlock scenario with smp_send_stop()

On Wed, Jul 24, 2013 at 11:56:18AM -0700, Stephen Boyd wrote:
> On 07/09, Stephen Boyd wrote:
> > If one process calls sys_reboot and that process then stops other
> > CPUs while those CPUs are within a spin_lock() region we can
> > potentially encounter a deadlock scenario like below.
> > 
> > CPU 0                   CPU 1
> > -----                   -----
> >                         spin_lock(my_lock)
> > smp_send_stop()
> >  <send IPI>             handle_IPI()
> >                          disable_preemption/irqs
> >                           while(1);
> >  <PREEMPT>
> > spin_lock(my_lock) <--- Waits forever
> > 
> > We shouldn't attempt to run any other tasks after we send a stop
> > IPI to a CPU so disable preemption so that this task runs to
> > completion.
> > 
> > Reported-by: Sundarajan Srinivasan <sundaraj@...eaurora.com>
> > Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> > ---
> > 
> > Resending this patch now that the context has changed.
> 
> Ping? Shall I put this in the patch tracker?

Well, looking at x86, they use local_irq_disable() before sending the
stop, so I think we should do the same for cross-arch consistency.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/