linux-kernel - Re: [PATCH 2/2] Drivers: hv: balloon: Online the hot-added memory "in context"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Jul 2013 14:04:15 -0700
From:	Dave Hansen <dave@...1.net>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>
CC:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, olaf@...fle.de, apw@...onical.com,
	andi@...stfloor.org, akpm@...ux-foundation.org, linux-mm@...ck.org,
	kamezawa.hiroyuki@...il.com, mhocko@...e.cz, hannes@...xchg.org,
	yinghan@...gle.com
Subject: Re: [PATCH 2/2] Drivers: hv: balloon: Online the hot-added memory
 "in context"

On 07/24/2013 02:29 PM, K. Y. Srinivasan wrote:
>  		/*
> -		 * Wait for the memory block to be onlined.
> -		 * Since the hot add has succeeded, it is ok to
> -		 * proceed even if the pages in the hot added region
> -		 * have not been "onlined" within the allowed time.
> +		 * Before proceeding to hot add the next segment,
> +		 * online the segment that has been hot added.
>  		 */
> -		wait_for_completion_timeout(&dm_device.ol_waitevent, 5*HZ);
> +		online_memory_block(start_pfn);

Ahhhhh....  You've got a timeout in the code in order to tell the
hypervisor that you were successfully able to add the memory?  The
userspace addition code probably wasn't running within this timeout
period.  right?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/