linux-kernel - Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130724215340.GY5585@mwanda>
Date:	Thu, 25 Jul 2013 00:53:40 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Won Kang <wkang77@...il.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org, wonkang@...semi.com
Subject: Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

> +static int gdm_lte_ioctl_get_data(struct wm_req_t *req, struct net_device *dev)
> +{
> +	u16 id = req->data_id;
> +
> +	switch (id) {
> +	case GET_ENDIAN_INFO:
> +		/* required for the user space application to find out device endian */
> +		get_dev_endian(&req->data, dev);
> +		break;
> +	default:
> +		printk(KERN_ERR "glte: ioctl - unknown type %d\n", id);
> +		break;
> +	}
> +	return 0;
> +}

This should be a sysfs file not an ioctl.  What would break if we
fixed this right now (as opposed to waiting until we can't change
the API?).

Otherwise if we can't change this, then it should return an error
code instead of printing a message.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/