linux-kernel - Re: [PATCH 4/5] SLIP: Add error message for xleft non-zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130724221849.GD21709@kroah.com>
Date:	Wed, 24 Jul 2013 15:18:49 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Dean Jenkins <Dean_Jenkins@...tor.com>
Cc:	Andre Naujoks <nautsch2@...il.com>, linux-kernel@...r.kernel.org,
	Jiri Slaby <jslaby@...e.cz>
Subject: Re: [PATCH 4/5] SLIP: Add error message for xleft non-zero

On Tue, Jul 02, 2013 at 04:31:33PM +0100, Dean Jenkins wrote:
> Add a printk to show when xleft is non-zero in sl_encaps.
> 
> The idea is to see whether a previous SLIP frame failed to be
> fully transmitted.
> 
> Signed-off-by: Dean Jenkins <Dean_Jenkins@...tor.com>
> ---
>  drivers/net/slip/slip.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/slip/slip.c b/drivers/net/slip/slip.c
> index f7303e0..e2eff84 100644
> --- a/drivers/net/slip/slip.c
> +++ b/drivers/net/slip/slip.c
> @@ -395,6 +395,10 @@ static void sl_encaps(struct slip *sl, unsigned char *icp, int len)
>  #endif
>  		count = slip_esc(p, sl->xbuff, len);
>  
> +	if (sl->xleft)
> +		printk(KERN_ERR "%s: ERROR: xleft is non-zero %d\n",
> +		       __func__, sl->xleft);

dev_err() perhaps?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/