linux-kernel - Re: [40/85] net/tg3: Avoid delay during MMIO access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1374725713.18653.49.camel@deadeye.wl.decadent.org.uk>
Date:	Thu, 25 Jul 2013 05:15:13 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Luis Henriques <luis.henriques@...onical.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	akpm@...ux-foundation.org, "David S. Miller" <davem@...emloft.net>,
	Gavin Shan <shangw@...ux.vnet.ibm.com>
Subject: Re: [40/85] net/tg3: Avoid delay during MMIO access

On Wed, 2013-07-24 at 17:42 +0100, Luis Henriques wrote:
> Ben Hutchings <ben@...adent.org.uk> writes:
> 
> > 3.2.49-rc1 review patch.  If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Gavin Shan <shangw@...ux.vnet.ibm.com>
> >
> > commit 6d446ec32f169c6a5d9bc90684a8082a6cbe90f6 upstream.
[...]
> > @@ -3067,6 +3085,10 @@ static int tg3_halt_cpu(struct tg3 *tp,
> >  			tw32(offset + CPU_MODE,  CPU_MODE_HALT);
> >  			if (tr32(offset + CPU_MODE) & CPU_MODE_HALT)
> >  				break;
> > +			if (pci_channel_offline(tp->pdev))
> > +				return -EBUSY;
> > +			if (pci_channel_offline(tp->pdev))
> > +				return -EBUSY;
> >  		}
> 
> I believe you didn't want to have these two invocations to the
> pci_channel_offline() function.  i guess you wanted to have one of
> these moved to the other branch of the 'if' statement.

Indeed, and I've dropped this patch.  This was partly due to a bug in
the patch command.  If there are two consecutive hunks which only insert
lines and have the same context, and it can only find one match for the
context, it will apply both insertions in the same place.

Ben.

> [ btw, I've just replied to an email by David S. Miller about his
>   backport to 3.4 (and 3.2) of this commit. ]
> 
> Cheers,

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)