linux-kernel - Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130725043741.GA11906@kroah.com>
Date:	Wed, 24 Jul 2013 21:37:41 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Won Kang <wkang77@...il.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	devel@...verdev.osuosl.org, wonkang@...semi.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver


A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Jul 25, 2013 at 01:15:07PM +0900, Won Kang wrote:
> GDM7240 is in LE where as GDM7243 (currently under development) is in BE.

But why does this information need to be sent to userspace?

> User space applications needs to discover the endianess to properly
> encode/decode LTE control protocols. We have existing customers
> already deploying units in large volume, and want to avoid forcing
> them to change SDK APIs along with kernel updates.
> At some point, It will have to be fixed with SDK API can interoperate properly.

Ugh, really?  What special tools does userspace need to talk to this
device?  It "should" just be a network device, and a serial port, why
does the endianness of the device mean anything?

Custom ioctls aren't ok for new drivers, if at all possible.  Can't
userspace just trigger this based on the device id instead?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/