[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130725080800.GC3403@laptop>
Date: Thu, 25 Jul 2013 09:08:00 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Philipp Zabel <p.zabel@...gutronix.de>
Cc: linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>,
Krystian Garbaciak <krystian.garbaciak@...semi.com>,
Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.
> > Signed-off-by: Krystian Garbaciak <krystian.garbaciak@...semi.com>
> > Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> > ---
> > drivers/mfd/Kconfig | 12 +
> > drivers/mfd/Makefile | 3 +
> > drivers/mfd/da9063-core.c | 177 ++++++
> > drivers/mfd/da9063-i2c.c | 197 ++++++
> > drivers/mfd/da9063-irq.c | 193 ++++++
> > include/linux/mfd/da9063/core.h | 110 ++++
> > include/linux/mfd/da9063/pdata.h | 114 ++++
> > include/linux/mfd/da9063/registers.h | 1090 ++++++++++++++++++++++++++++++++++
> > 8 files changed, 1896 insertions(+)
>
> Whoah!! Who's going to want to review a 2k line patch?
>
> Any chance you can split this stuff up into more 'bite sized' patches?
You also missed Sam off the addressees list, which is not a good idea.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists