linux-kernel - Re: [PATCH v5] regulator: pfuze100: add pfuze100 regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130725084042.GA19368@S2101-09.ap.freescale.net>
Date:	Thu, 25 Jul 2013 16:40:44 +0800
From:	Shawn Guo <shawn.guo@...aro.org>
To:	Robin Gong <b38343@...escale.com>
CC:	<broonie@...nel.org>, <grant.likely@...aro.org>,
	<rob.herring@...xeda.com>, <rob@...dley.net>,
	<lgirdwood@...il.com>, <devicetree-discuss@...ts.ozlabs.org>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<s.trumtrar@...gutronix.de>
Subject: Re: [PATCH v5] regulator: pfuze100: add pfuze100 regulator driver

On Thu, Jul 25, 2013 at 11:33:18AM +0800, Robin Gong wrote:
> @@ -0,0 +1,113 @@
> +PFUZE100 family of regulators
> +
> +Required properties:
> +- compatible: "fsl,pfuze100"
> +- reg: I2C slave address
> +- regulators: This is the list of child nodes that specify the regulator
> +  initialization data for defined regulators. Please refer to below doc
> +  Documentation/devicetree/bindings/regulator/regulator.txt.

I had the comment on v4 patch.  The "regulators" should not be
documented as a property but a sub-node, because it's not a property
but sub-node.

Shawn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/