linux-kernel - Re: v3.11-rc1 USB regressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 25 Jul 2013 11:08:03 +0200
From:	Daniel Mack <zonque@...il.com>
To:	Aaro Koskinen <aaro.koskinen@....fi>
CC:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: v3.11-rc1 USB regressions

On 25.07.2013 02:30, Aaro Koskinen wrote:
> On Wed, Jul 24, 2013 at 09:04:28PM +0200, Daniel Mack wrote:
>> On 24.07.2013 20:51, Aaro Koskinen wrote:
>>>> When I revert fe4cb0912f8e737f8e4b8b38b9e692f8062f5423 and
>>>> 8b125df5b24cfb0ec7fa1971e343cc0badc1827d, it works like before (3.10):
>>>
>>> I'm now running -rc2 with above fixes and reverts (the only way to get
>>> USB working). I'm seeing an additional issue, the following crash happens
>>> always on N900 when doing "poweroff":
>>
>> Yes, with the mentioned patches reverted, musb_to_hcd() will return a
>> faulty pointer. You can't easily revert them unfortunately.
>>
>> Your platform needs a real fix, I just have trouble understanding why a
>> removed usb_add_hcd() would make the gadget code fail.
>>
>> Sorry for the trouble, but I don't currently have a board with musb in
>> gadget mode to reproduce this issue.
> 
> If you have any ideas what to look for, I can maybe try to debug this
> issue.

Please try changing the .mode field of musb_board_data to MUSB_OTG in
your board file (arch/arm/mach-omap2/board-rx51.c). That should bring
back the call to usb_add_hcd(), provided that you have USB_MUSB_DUAL_ROLE=y.

I still don't see a reason why this is should be necessary for
peripheral-only use though.


Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/