linux-kernel - Re: [PATCH] video: xilinxfb: Fix compilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXnkN39A1z-Ejd247KHs-=kVBcBX0rbSp=gtye=E-Wzow@mail.gmail.com>
Date:	Thu, 25 Jul 2013 12:09:39 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Michal Simek <monstr@...str.eu>
Cc:	Jingoo Han <jg1.han@...sung.com>,
	Michal Simek <michal.simek@...inx.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Stepan Moskovchenko <stepanm@...eaurora.org>
Subject: Re: [PATCH] video: xilinxfb: Fix compilation warning

On Wed, Jul 24, 2013 at 10:24 AM, Michal Simek <monstr@...str.eu> wrote:
>> Just now, I tested that the same problem happens on ARM config.
>> Also, I solved it by adding '&' operator.
>>
>> '&' operator is necessary as below:
>>
>>         dev_dbg(dev, "regs: phys=%pa, virt=%p\n",
>>                  &drvdata->regs_phys, drvdata->regs);
>>                 ^^^
>>
>>         dev_dbg(dev, "fb: phys=%pa, virt=%p, size=%x\n",
>>                 &drvdata->fb_phys, drvdata->fb_virt, fbsize);
>>                ^^^
>
> ok.
>
> The truth is as I said there are just 5 files in the whole kernel
> which are using %pa and if %pa is right way to go we should
> probably fix all off them.

"%pa" is a quite recent addition (v3.9).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/