linux-kernel - Re: [PATCH v2 2/7] usb: phy: msm: Migrate to Managed Device Resource allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1374759740.1956.30.camel@iivanov-dev.int.mm-sol.com>
Date:	Thu, 25 Jul 2013 16:42:20 +0300
From:	"Ivan T. Ivanov" <iivanov@...sol.com>
To:	balbi@...com
Cc:	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v2 2/7] usb: phy: msm: Migrate to Managed Device
 Resource allocation


Hi, 

On Wed, 2013-07-24 at 15:38 +0300, Felipe Balbi wrote:
> Hi,
> 
> On Tue, Jul 09, 2013 at 06:47:08PM +0300, Ivan T. Ivanov wrote:
> > From: "Ivan T. Ivanov" <iivanov@...sol.com>
> > 
> > Use managed device resources to clean up the probe/remove
> > and get DT support for free.
> > 
> > Signed-off-by: Ivan T. Ivanov <iivanov@...sol.com>
> > ---
> >  drivers/usb/phy/phy-msm-usb.c |   78 +++++++++++------------------------------
> >  1 file changed, 20 insertions(+), 58 deletions(-)
> > 
> > diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> > index ab1b880..cc37f5e 100644
> > --- a/drivers/usb/phy/phy-msm-usb.c
> > +++ b/drivers/usb/phy/phy-msm-usb.c
> > @@ -1458,30 +1455,27 @@ static int __init msm_otg_probe(struct platform_device *pdev)
> >  	 * clock is introduced to remove the dependency on AXI
> >  	 * bus frequency.
> >  	 */
> > -	motg->core_clk = clk_get(&pdev->dev, "usb_hs_core_clk");
> > +	motg->core_clk = devm_clk_get(&pdev->dev, "usb_hs_core_clk");
> >  	if (IS_ERR(motg->core_clk))
> >  		motg->core_clk = NULL;
> >  
> >  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >  	if (!res) {
> 
> no need to check for the resource when using devm_ioremap_resource()
> 
> >  		dev_err(&pdev->dev, "failed to get platform resource mem\n");
> > -		ret = -ENODEV;
> > -		goto put_core_clk;
> > +		return -ENODEV;
> >  	}
> >  
> > -	motg->regs = ioremap(res->start, resource_size(res));
> > +	motg->regs = devm_ioremap_resource(&pdev->dev, res);
> >  	if (!motg->regs) {
> >  		dev_err(&pdev->dev, "ioremap failed\n");
> 
> don't print error messages when using devm_ioremap_resource()

Will fix these places and re-send,

Thank you,
Ivan



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/