linux-kernel - Re: [Intel-gfx] linux-next: Tree for Jul 25 [ call-trace: drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130725180301.GB11514@cantiga.alporthouse.com>
Date:	Thu, 25 Jul 2013 19:03:01 +0100
From:	Chris Wilson <chris@...is-wilson.co.uk>
To:	Sedat Dilek <sedat.dilek@...il.com>
Cc:	Daniel Vetter <daniel.vetter@...ll.ch>,
	Jani Nikula <jani.nikula@...ux.intel.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	intel-gfx <intel-gfx@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	DRI <dri-devel@...ts.freedesktop.org>,
	linux-next <linux-next@...r.kernel.org>
Subject: Re: [Intel-gfx] linux-next: Tree for Jul 25 [ call-trace: drm |
 drm-intel related? ]

On Thu, Jul 25, 2013 at 07:52:22PM +0200, Sedat Dilek wrote:
> On Thu, Jul 25, 2013 at 7:26 PM, Chris Wilson <chris@...is-wilson.co.uk> wrote:
> > On Thu, Jul 25, 2013 at 07:15:03PM +0200, Sedat Dilek wrote:
> >> On Thu, Jul 25, 2013 at 7:01 PM, Chris Wilson <chris@...is-wilson.co.uk> wrote:
> >> > Basically boils down to either an object allocation failure or mmaping
> >> > failure. I think dmesg with drm.debug=7 is the next step.
> >>
> >> Attached! Thanks for taking care.
> >
> > Hmm, looks like i915_gem_map_gtt fails, but no reason given, so can you
> > please apply this for more debug:
> >
> > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> > index 0563661..34e09bf 100644
> > --- a/drivers/gpu/drm/i915/i915_gem.c
> > +++ b/drivers/gpu/drm/i915/i915_gem.c
> > @@ -1630,24 +1630,29 @@ i915_gem_mmap_gtt(struct drm_file *file,
> >
> >         obj = to_intel_bo(drm_gem_object_lookup(dev, file, handle));
> >         if (&obj->base == NULL) {
> > +               DRM_DRIVER_DEBUG("Unknown object handle %d\n", handle);
> >                 ret = -ENOENT;
> >                 goto unlock;
> >         }
> >
> >         if (obj->base.size > dev_priv->gtt.mappable_end) {
> > +               DRM_DRIVER_DEBUG("Object (%d) larger than mappable aperture (%d) > %d\n",
> > +                               (int)obj->base.size, (int)dev_priv->gtt.mappable_end);
> >                 ret = -E2BIG;
> >                 goto out;
> >         }
> >
> >         if (obj->madv != I915_MADV_WILLNEED) {
> > -               DRM_ERROR("Attempting to mmap a purgeable buffer\n");
> > +               DRM_DRIVER_DEBUG("Attempting to mmap a purgeable buffer\n");
> >                 ret = -EINVAL;
> >                 goto out;
> >         }
> >
> >         ret = i915_gem_object_create_mmap_offset(obj);
> > -       if (ret)
> > +       if (ret) {
> > +               DRM_DRIVER_DEBUG("Failed to allocate mmap offset (ret=%d)\n", ret);
> >                 goto out;
> > +       }
> >
> >         *offset = (u64)obj->base.map_list.hash.key << PAGE_SHIFT;
> >
> > --
> 
> This does not apply... After refreshing and some cleanups... does not build:
> 
> $ LANG=C LC_ALL=C make M=drivers/gpu/drm/i915
>   LD      drivers/gpu/drm/i915/built-in.o
>   CC [M]  drivers/gpu/drm/i915/i915_drv.o
>   CC [M]  drivers/gpu/drm/i915/i915_dma.o
>   CC [M]  drivers/gpu/drm/i915/i915_irq.o
>   CC [M]  drivers/gpu/drm/i915/i915_debugfs.o
>   CC [M]  drivers/gpu/drm/i915/i915_gpu_error.o
>   CC [M]  drivers/gpu/drm/i915/i915_suspend.o
>   CC [M]  drivers/gpu/drm/i915/i915_gem.o
> drivers/gpu/drm/i915/i915_gem.c: In function 'i915_gem_mmap_gtt':
> drivers/gpu/drm/i915/i915_gem.c:1538:3: error: implicit declaration of
> function 'DRM_DRIVER_DEBUG' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[1]: *** [drivers/gpu/drm/i915/i915_gem.o] Error 1
> make: *** [_module_drivers/gpu/drm/i915] Error 2

Bah, try DRM_DEBUG_DRIVER instead.
-Chris


-- 
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/