linux-kernel - Re: [PATCH 15/21] x86, acpi, numa: Don't reserve memory on nodes the kernel resides in.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51F08ED0.9080407@cn.fujitsu.com>
Date:	Thu, 25 Jul 2013 10:34:56 +0800
From:	Tang Chen <tangchen@...fujitsu.com>
To:	Tejun Heo <tj@...nel.org>
CC:	tglx@...utronix.de, mingo@...e.hu, hpa@...or.com,
	akpm@...ux-foundation.org, trenn@...e.de, yinghai@...nel.org,
	jiang.liu@...wei.com, wency@...fujitsu.com, laijs@...fujitsu.com,
	isimatu.yasuaki@...fujitsu.com, izumi.taku@...fujitsu.com,
	mgorman@...e.de, minchan@...nel.org, mina86@...a86.com,
	gong.chen@...ux.intel.com, vasilis.liaskovitis@...fitbricks.com,
	lwoodman@...hat.com, riel@...hat.com, jweiner@...hat.com,
	prarit@...hat.com, zhangyanfei@...fujitsu.com,
	yanghy@...fujitsu.com, x86@...nel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH 15/21] x86, acpi, numa: Don't reserve memory on nodes
 the kernel resides in.

On 07/24/2013 04:59 AM, Tejun Heo wrote:
......
>> +static bool __init kernel_resides_in_range(phys_addr_t base, u64 length)
>> +{
>> +	int i;
>> +	struct memblock_type *reserved =&memblock.reserved;
>> +	struct memblock_region *region;
>> +	phys_addr_t start, end;
>> +
>> +	for (i = 0; i<  reserved->cnt; i++) {
>> +		region =&reserved->regions[i];
>> +
>> +		if (region->flags != MEMBLK_FLAGS_DEFAULT)
>> +			continue;
>> +
>> +		start = region->base;
>> +		end = region->base + region->size;
>> +		if (end<= base || start>= base + length)
>> +			continue;
>> +
>> +		return true;
>> +	}
>> +
>> +	return false;
>> +}
>
> This being in acpi/osl.c is rather weird.  Overall, the acpi and
> memblock parts don't seem very well split.  It'd best if acpi just
> indicates which regions are hotpluggable and the rest is handled by
> x86 boot or memblock code as appropriate.

OK. Will move this function out from acpi side.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/