linux-kernel - Re: [PATCH] numa: Mark __node_set as __always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 25 Jul 2013 14:50:08 -0400
From:	Tom Rini <trini@...com>
To:	KOSAKI Motohiro <kosaki.motohiro@...il.com>
CC:	<linux-kernel@...r.kernel.org>, <x86@...nel.org>,
	Jianpeng Ma <majianpeng@...il.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>,
	Wen Congyang <wency@...fujitsu.com>,
	Jiang Liu <jiang.liu@...wei.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Minchan Kim <minchan.kim@...il.com>,
	Mel Gorman <mgorman@...e.de>,
	David Rientjes <rientjes@...gle.com>,
	Yinghai Lu <yinghai@...nel.org>, Greg KH <greg@...ah.com>
Subject: Re: [PATCH] numa: Mark __node_set as __always_inline

On 07/25/2013 02:08 PM, KOSAKI Motohiro wrote:
> (7/25/13 8:14 AM), Tom Rini wrote:
>> It is posible for some compilers to decide that __node_set does not need
>> to be made turned into an inline function.  When the compiler does this
>> on an __init function calling it on __initdata we get a section mismatch
>> warning now.
>>
>> Reported-by: Paul Bolle <pebolle@...cali.nl>
>> Cc: Jianpeng Ma <majianpeng@...il.com>
>> Cc: Rusty Russell <rusty@...tcorp.com.au>
>> Cc: Lai Jiangshan <laijs@...fujitsu.com>
>> Cc: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
>> Cc: Wen Congyang <wency@...fujitsu.com>
>> Cc: Jiang Liu <jiang.liu@...wei.com>
>> Cc: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
>> Cc: Minchan Kim <minchan.kim@...il.com>
>> Cc: Mel Gorman <mgorman@...e.de>
>> Cc: David Rientjes <rientjes@...gle.com>
>> Cc: Yinghai Lu <yinghai@...nel.org>
>> Cc: Greg KH <greg@...ah.com>
>> Signed-off-by: Tom Rini <trini@...com>
>> ---
>>   include/linux/nodemask.h |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h
>> index 4e2cbfa..10d0fd9 100644
>> --- a/include/linux/nodemask.h
>> +++ b/include/linux/nodemask.h
>> @@ -99,7 +99,7 @@ typedef struct { DECLARE_BITMAP(bits, MAX_NUMNODES); } nodemask_t;
>>   extern nodemask_t _unused_nodemask_arg_;
>>   
>>   #define node_set(node, dst) __node_set((node), &(dst))
>> -static inline void __node_set(int node, volatile nodemask_t *dstp)
>> +static __always_inline void __node_set(int node, volatile nodemask_t *dstp)
> 
> The change looks ok. But, this code doesn't tell us why you changed. Please write
> down proper comments here.

Done, v2 submitted.

-- 
Tom
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/