linux-kernel - Re: [PATCH 6/8] staging/lustre: fix Kconfig bool defaults

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+a=Yy7ykdzJ4gWc7GKF9RLOtzjomaFpkw8JEhHbgRPj2=5hzw@mail.gmail.com>
Date:	Thu, 25 Jul 2013 10:36:45 +0800
From:	Peng Tao <bergwolf@...il.com>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	mail-agent-noreply@....com,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andreas Dilger <andreas.dilger@...el.com>
Subject: Re: [PATCH 6/8] staging/lustre: fix Kconfig bool defaults

On Thu, Jul 25, 2013 at 3:35 AM, Sam Ravnborg <sam@...nborg.org> wrote:
> On Wed, Jul 24, 2013 at 04:31:30PM +0800, mail-agent-noreply@....com wrote:
>> From: Peng Tao <bergwolf@...il.com>
>>
>> Should be y instead of true.
>>
>> Reported-by: Paul Bolle <pebolle@...cali.nl>
>> Cc: Andreas Dilger <andreas.dilger@...el.com>
>> Signed-off-by: Peng Tao <tao.peng@....com>
>> ---
>>  drivers/staging/lustre/lustre/Kconfig |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
>> index 9ae7fa8..e3b3c74 100644
>> --- a/drivers/staging/lustre/lustre/Kconfig
>> +++ b/drivers/staging/lustre/lustre/Kconfig
>> @@ -52,4 +52,4 @@ config LUSTRE_DEBUG_EXPENSIVE_CHECK
>>  config LUSTRE_TRANSLATE_ERRNOS
>>       bool
>>       depends on LUSTRE_FS && !X86
>> -     default true
>> +     default y
>
> This was the file that contained some buggy "default false" IIRC.
> Please delete these.
>
The default false lines were already deleted by Paul Bolle.
Please see commit 68a8029799ad368ee82a5cf509a2b5b802837ce9 in Greg's
staging-next branch.

commit 68a8029799ad368ee82a5cf509a2b5b802837ce9
Author: Paul Bolle <pebolle@...cali.nl>
Date:   Sat Jul 13 20:46:39 2013 +0200

    staging/lustre/libcfs: drop bogus Kconfig default

    Commit 4b5b4c7222 ("staging/lustre/libcfs: restore LINVRNT") added
    "default false" to this Kconfig file. It was obviously meant to use
    "default n" here. But we might as well drop this line, as a Kconfig bool
    defaults to 'n' anyway.

    Signed-off-by: Paul Bolle <pebolle@...cali.nl>
    Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Thanks,
Tao
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/