| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Jul 2013 20:10:59 +0100
From: Mark Brown <broonie@...nel.org>
To: Jean-Francois Moine <moinejf@...e.fr>
Cc: Liam Girdwood <lgirdwood@...il.com>,
Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
Rob Herring <rob.herring@...xeda.com>,
Russell King <rmk+kernel@....linux.org.uk>,
alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH 2/4] ASoc: kirkwood: simplify probe error
On Thu, Jul 25, 2013 at 11:13:57AM +0200, Jean-Francois Moine wrote:
> The function kirkwood_i2s_dev_remove() may be used when probe fails.
This seems fine but doesn't apply against current code but otherwise
seems fine.
> + if (!IS_ERR(priv->extclk)) {
> + clk_disable_unprepare(priv->extclk);
> + clk_put(priv->extclk);
> + }
Could use devm_clk_get() for extclk.
Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)
Powered by blists - more mailing lists