linux-kernel - Re: [PATCH 4/4] ASoc: kirkwood: add DT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130725191905.GR9858@sirena.org.uk>
Date:	Thu, 25 Jul 2013 20:19:05 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Jean-Francois Moine <moinejf@...e.fr>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Rob Herring <rob.herring@...xeda.com>,
	Russell King <rmk+kernel@....linux.org.uk>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 4/4] ASoc: kirkwood: add DT support

On Thu, Jul 25, 2013 at 11:14:59AM +0200, Jean-Francois Moine wrote:

> +	if (np) {
> +		priv->burst = 128;		/* might be 32 or 128 */
> +	} else if (data) {

When you posted this before I queried how and why the value might vary -
I see the code is the same and I don't recall a reply.

> -	priv->clk = devm_clk_get(&pdev->dev, NULL);
> +	priv->clk = devm_clk_get(&pdev->dev, "internal");
>  	if (IS_ERR(priv->clk)) {
> -		dev_err(&pdev->dev, "no clock\n");
> +		dev_err(&pdev->dev, "no internal clock\n");
>  		return PTR_ERR(priv->clk);
>  	}

Does the code providing it already name the clock?  If not are updates
needed to do that?

> -	priv->extclk = clk_get(&pdev->dev, "extclk");
> +	priv->extclk = clk_get(&pdev->dev, "external");

Is the clock actually called extclk in the datasheet and so on?  If so
it seems better to stick with that name.  Do any boards need updates for
the new name?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)