linux-kernel - Re: qlcnic binary sysfs file abuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130725.140933.1460349218585474906.davem@davemloft.net>
Date:	Thu, 25 Jul 2013 14:09:33 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sony.chacko@...gic.com
Cc:	gregkh@...uxfoundation.org, rajesh.borundia@...gic.com,
	shahed.shaikh@...gic.com, jitendra.kalsaria@...gic.com,
	Linux-Driver@...gic.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: qlcnic binary sysfs file abuse

From: Sony Chacko <sony.chacko@...gic.com>
Date: Thu, 25 Jul 2013 19:37:46 +0000

>> -----Original Message-----
>> From: Greg KH [mailto:gregkh@...uxfoundation.org]
>> Sent: Saturday, July 06, 2013 5:30 PM
>> To: Rajesh Borundia; Shahed Shaikh; Jitendra Kalsaria; Sony Chacko; Dept-Eng
>> Linux Driver
>> Cc: netdev; linux-kernel
>> Subject: qlcnic binary sysfs file abuse
>> 
>> I was doing a kernel-wide audit on all of the binary sysfs files, and noticed a
>> metric ton of them in the qlcnic driver.
>> 
>> So, any objection to me just deleting these entirely?  Or, if they really are
>> needed, can I just move them to debugfs, which is where I think they should
>> have been from the beginning?
> 
> Some applications are using these files, please move them to debugfs.

This is quite a mess, and I've complained about all of the crazy
files created by qlcnic in the past.

debugfs is for things that do not create a ABI which the kernel has to
maintain forever.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/