linux-kernel - Re: [PATCH V8 29/33] udf: convert file ops from aio_read/write to read/write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130725213433.GB18011@quack.suse.cz>
Date:	Thu, 25 Jul 2013 23:34:33 +0200
From:	Jan Kara <jack@...e.cz>
To:	Dave Kleikamp <dave.kleikamp@...cle.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Maxim V. Patlasov" <mpatlasov@...allels.com>,
	Zach Brown <zab@...bo.net>, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH V8 29/33] udf: convert file ops from aio_read/write to
 read/write_iter

On Thu 25-07-13 12:50:55, Dave Kleikamp wrote:
> Signed-off-by: Dave Kleikamp <dave.kleikamp@...cle.com>
> Cc: Jan Kara <jack@...e.cz>
  Looks good. You can add:
Acked-by: Jan Kara <jack@...e.cz>

								Honza
> ---
>  fs/udf/file.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/udf/file.c b/fs/udf/file.c
> index 339df8b..e392d60 100644
> --- a/fs/udf/file.c
> +++ b/fs/udf/file.c
> @@ -133,8 +133,8 @@ const struct address_space_operations udf_adinicb_aops = {
>  	.direct_IO	= udf_adinicb_direct_IO,
>  };
>  
> -static ssize_t udf_file_aio_write(struct kiocb *iocb, const struct iovec *iov,
> -				  unsigned long nr_segs, loff_t ppos)
> +static ssize_t udf_file_write_iter(struct kiocb *iocb, struct iov_iter *iter,
> +				   loff_t ppos)
>  {
>  	ssize_t retval;
>  	struct file *file = iocb->ki_filp;
> @@ -168,7 +168,7 @@ static ssize_t udf_file_aio_write(struct kiocb *iocb, const struct iovec *iov,
>  	} else
>  		up_write(&iinfo->i_data_sem);
>  
> -	retval = generic_file_aio_write(iocb, iov, nr_segs, ppos);
> +	retval = generic_file_write_iter(iocb, iter, ppos);
>  	if (retval > 0)
>  		mark_inode_dirty(inode);
>  
> @@ -242,12 +242,12 @@ static int udf_release_file(struct inode *inode, struct file *filp)
>  
>  const struct file_operations udf_file_operations = {
>  	.read			= do_sync_read,
> -	.aio_read		= generic_file_aio_read,
> +	.read_iter		= generic_file_read_iter,
>  	.unlocked_ioctl		= udf_ioctl,
>  	.open			= generic_file_open,
>  	.mmap			= generic_file_mmap,
>  	.write			= do_sync_write,
> -	.aio_write		= udf_file_aio_write,
> +	.write_iter		= udf_file_write_iter,
>  	.release		= udf_release_file,
>  	.fsync			= generic_file_fsync,
>  	.splice_read		= generic_file_splice_read,
> -- 
> 1.8.3.4
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/