linux-kernel - Re: [PATCH 0/4] iommu: Add event tracing feature to iommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 25 Jul 2013 23:11:16 +0000
From:	Shuah Khan <shuah.kh@...sung.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	"joro@...tes.org" <joro@...tes.org>,
	"alex.williamson@...hat.com" <alex.williamson@...hat.com>,
	"Varun.Sethi@...escale.com" <Varun.Sethi@...escale.com>,
	"aik@...abs.ru" <aik@...abs.ru>,
	"joe@...ches.com" <joe@...ches.com>,
	"fweisbec@...il.com" <fweisbec@...il.com>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"tony@...mide.com" <tony@...mide.com>,
	"ohad@...ery.com" <ohad@...ery.com>,
	"andreas.herrmann@...xeda.com" <andreas.herrmann@...xeda.com>,
	"will.deacon@....com" <will.deacon@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
	"shuahkhan@...il.com" <shuahkhan@...il.com>,
	Shuah Khan <shuah.kh@...sung.com>
Subject: Re: [PATCH 0/4] iommu: Add event tracing feature to iommu

On 07/25/2013 07:27 AM, Steven Rostedt wrote:
> On Thu, 2013-07-25 at 07:15 -0600, Shuah Khan wrote:
>
>> Shuah Khan (4):
>>    iommu: Add event tracing feature to iommu - Add iommu trace events
>>    iommu: Add event tracing feature to iommu - export trace events
>>    iommu: Add event tracing feature to iommu - amd_iommu driver trace
>>      events
>>    iommu: Add event tracing feature to iommu - iommu driver trace events
>>
>>   drivers/iommu/Makefile       |    1 +
>>   drivers/iommu/amd_iommu.c    |   19 +++++
>>   drivers/iommu/iommu-traces.c |   27 +++++++
>>   drivers/iommu/iommu.c        |   17 ++++-
>>   include/trace/events/iommu.h |  174 ++++++++++++++++++++++++++++++++++++++++++
>>   5 files changed, 237 insertions(+), 1 deletion(-)
>>   create mode 100644 drivers/iommu/iommu-traces.c
>>   create mode 100644 include/trace/events/iommu.h
>
> I don't know what the maintainer thinks, but usually new tracepoints
> like this are done as one patch. Not four.
>
> -- Steve
>

If one single patch is preferred, I can easily generate one. Does the 
code look good otherwise?

-- Shuah

Shuah Khan, Linux Kernel Developer - Open Source Group Samsung Research 
America (Silicon Valley) shuah.kh@...sung.com | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/