linux-kernel - Re: [PATCH] matroxfb: replace kmalloc and memset with kzalloc.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51F2351D.6010904@ti.com>
Date:	Fri, 26 Jul 2013 11:36:45 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Alexandru Juncu <alexj@...edu.org>
CC:	<plagnioj@...osoft.com>, <linux-fbdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] matroxfb: replace kmalloc and memset with kzalloc.

On 12/07/13 17:00, Alexandru Juncu wrote:
> Signed-off-by: Alexandru Juncu <alexj@...edu.org>
> ---
>  drivers/video/matrox/matroxfb_base.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/video/matrox/matroxfb_base.c b/drivers/video/matrox/matroxfb_base.c
> index 401a56e..2456529 100644
> --- a/drivers/video/matrox/matroxfb_base.c
> +++ b/drivers/video/matrox/matroxfb_base.c
> @@ -2029,10 +2029,9 @@ static int matroxfb_probe(struct pci_dev* pdev, const struct pci_device_id* dumm
>  		return -1;
>  	}
>  
> -	minfo = kmalloc(sizeof(*minfo), GFP_KERNEL);
> +	minfo = kzalloc(sizeof(*minfo), GFP_KERNEL);
>  	if (!minfo)
>  		return -1;
> -	memset(minfo, 0, sizeof(*minfo));
>  
>  	minfo->pcidev = pdev;
>  	minfo->dead = 0;
> 

Thanks, I've applied this into my 3.12/fbdev branch.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (902 bytes)