linux-kernel - [PATCH] x86/PCI: MMCONFIG: cleanup and add address warning to pci_mmconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <51F23D0F.7090909@oracle.com>
Date:	Fri, 26 Jul 2013 17:10:39 +0800
From:	ethan zhao <ethan.zhao@...cle.com>
To:	jbarnes@...tuousgeek.org, bjorn.helgaas@...com
CC:	yinghai@...nel.org, linux-kernel@...r.kernel.org,
	ethan.kernel@...il.com
Subject: [PATCH] x86/PCI: MMCONFIG: cleanup and add address warning to pci_mmconfig_insert

Cleanup the -EINVAL return value handling and add warning message for 
invalid
start,end,addr parameters.

Signed-off-by: ethan.zhao <ethan.zhao@...cle.com>
---
  arch/x86/pci/mmconfig-shared.c |   12 ++++++------
  1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/x86/pci/mmconfig-shared.c b/arch/x86/pci/mmconfig-shared.c
index 082e881..37f6c7f 100644
--- a/arch/x86/pci/mmconfig-shared.c
+++ b/arch/x86/pci/mmconfig-shared.c
@@ -700,8 +700,13 @@ int pci_mmconfig_insert(struct device *dev, u16 
seg, u8 start, u8 end,
      if (!(pci_probe & PCI_PROBE_MMCONF) || pci_mmcfg_arch_init_failed)
          return -ENODEV;

-    if (start > end)
+    if (start > end || !addr) {
+        dev_warn(dev, FW_WARN
+                                 "Invalid address to add MMCONFIG"
+                                 "start %02x end %02x addr %pR\n",
+                                  start, end, addr);
          return -EINVAL;
+    }

      mutex_lock(&pci_mmcfg_lock);
      cfg = pci_mmconfig_lookup(seg, start);
@@ -716,11 +721,6 @@ int pci_mmconfig_insert(struct device *dev, u16 
seg, u8 start, u8 end,
          return -EEXIST;
      }

-    if (!addr) {
-        mutex_unlock(&pci_mmcfg_lock);
-        return -EINVAL;
-    }
-
      rc = -EBUSY;
      cfg = pci_mmconfig_alloc(seg, start, end, addr);
      if (cfg == NULL) {
-- 
1.7.1



View attachment "0001-x86-PCI-MMCONFIG-cleanup-and-add-address-warning-to-.patch" of type "text/x-patch" (1520 bytes)