linux-kernel - Re: [RESEND RFC PATCH 2/5] printk: add message hash values in /dev/kmsg output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <51F2672E.2090605@hitachi.com>
Date:	Fri, 26 Jul 2013 21:10:22 +0900
From:	Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>
To:	Kazuo Ito <kzpn200@...il.com>
Cc:	linux-kernel@...r.kernel.org, yrl.pp-manager.tt@...achi.com,
	akpm@...ux-foundation.org, gregkh@...uxfoundation.org,
	kay@...y.org, davem@...emloft.net, itoukzo@...data.co.jp
Subject: Re: [RESEND RFC PATCH 2/5] printk: add message hash values in /dev/kmsg
 output

Hello,

(2013/07/26 0:01), Kazuo Ito wrote:> Hello, again.
>
> On Thu, Jul 25, 2013 at 5:37 PM, Hidehiro Kawai <
> hidehiro.kawai.ez@...achi.com> wrote:
>
>> diff --git a/drivers/base/core.c b/drivers/base/core.c
>> index 8856d74..e2bf2af 100644
>> --- a/drivers/base/core.c
>> +++ b/drivers/base/core.c
>> @@ -2153,7 +2153,8 @@ int dev_vprintk_emit(int level, const struct device
>> *dev,
>>
>>         hdrlen = create_syslog_header(dev, hdr, sizeof(hdr));
>>
>> -       return vprintk_emit(0, level, hdrlen ? hdr : NULL, hdrlen, fmt,
>> args);
>> +       return vprintk_emit(0, level, hdrlen ? hdr : NULL, hdrlen,
>> +                           fmt, args, NULL);
>>  }
>>  EXPORT_SYMBOL(dev_vprintk_emit);
>>
>
>
>
> Position of struct kmsg_meta * arguments can be made more
> consistent. Because it can occur with va_list which comes
> last by convention, it should be brought to front of these
> lists of arguments. 

You are right.  It should be consistent.

So I will place kmsg_meta * in the front of fmt in the next version.
It would be preferred that the format string immediately followed by
variable arguments.

Regards,
-- 
Hidehiro Kawai
Hitachi, Yokohama Research Laboratory
Linux Technology Center


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/