linux-kernel - Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51F26BC6.2020300@suse.cz>
Date:	Fri, 26 Jul 2013 14:29:58 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	haver@...ux.vnet.ibm.com
Cc:	linux-kernel@...r.kernel.org, arnd@...db.de,
	gregkh@...uxfoundation.org, cody@...ux.vnet.ibm.com,
	schwidefsky@...ibm.com, utz.bacher@...ibm.com, jsvogt@...ibm.com,
	MIJUNG@...ibm.com, cascardo@...ux.vnet.ibm.com, michael@...ra.de
Subject: Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver

On 26.7.2013 14:20, Frank Haverkamp wrote:
> Hi Michael,
> 
> Am Donnerstag, den 25.07.2013, 15:21 +0200 schrieb Michal Marek:
>> On 25.7.2013 10:28, Frank Haverkamp wrote:
>>> +	dev_info(&pci_dev->dev, "GenWQE driver version: %s (build %s) %s%u\n",
>>> +		 DRV_VERS_STRING, __DATE__, GENWQE_DEVNAME, cd->card_idx);
>> [...]
>>> +	len += scnprintf(&buf[len], PAGE_SIZE - len,
>>> +			 "GenWQE driver version: %s (build %s)\n"
>>> +			 "    Device Name/Type: %s %s CardIdx: %d\n"
>>> +			 "    SLU/APP Config  : 0x%016llx/0x%016llx\n"
>>> +			 "    Build Date/Type : %u/%x/%u %s\n"
>>> +			 "    Base Clock      : %u MHz\n"
>>> +			 "    Arch/SVN Release: %u/%llx\n"
>>> +			 "    Bitstream       : %llx\n",
>>> +			 DRV_VERS_STRING, __DATE__, dev_name(&pci_dev->dev),
>>
>> Please remove the __DATE__ macros, so that the generated object code
>> does not literally change with the phase of the moon.
>>
>> Michal
> 
> Thanks for reviewing. I removed them in my copy. Would that be something
> scripts/checkpatch.pl could warn about?

I did submit a patch for checkpatch.pl to do exactly that, but it was
not applied. I will resend it, thanks for the reminder.

Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/