linux-kernel - Re: [PATCH] race condition fixing in sysfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130726134150.GE3013@htj.dyndns.org>
Date:	Fri, 26 Jul 2013 09:41:50 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Dennis Chen <xschen@...oft.com.cn>
Cc:	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
	xiyou.wangcong@...il.com
Subject: Re: [PATCH] race condition fixing in sysfs_create_dir

On Fri, Jul 26, 2013 at 09:38:56AM -0400, Tejun Heo wrote:
> I don't think sysfs is supposed to handle multiple actors trying to
> populate and destroy the directory at the same time at all, so this

e.g. kobj->sd assignment in sysfs_create_dir() isn't synchronized and
doesn't have memory barrier either.  Nothing prevents subdirectory
creation from accessing half-initialized sysfs_dirent on architectures
which require read dependency barriers.  The caller is responsible for
synchronizing these operations.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/