lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 26 Jul 2013 15:58:53 +0100 From: Matt Fleming <matt.fleming@...el.com> To: Roy Franz <roy.franz@...aro.org> CC: hpa@...or.com, tglx@...utronix.de, mingo@...hat.com, x86@...nel.org, linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] correct call to free_pages to specify memory size in pages, not bytes. On 25/07/13 01:48, Roy Franz wrote: > Signed-off-by: Roy Franz <roy.franz@...aro.org> > --- > arch/x86/boot/compressed/eboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c > index d606463..b7388a4 100644 > --- a/arch/x86/boot/compressed/eboot.c > +++ b/arch/x86/boot/compressed/eboot.c > @@ -225,7 +225,7 @@ static void low_free(unsigned long size, unsigned long addr) > unsigned long nr_pages; > > nr_pages = round_up(size, EFI_PAGE_SIZE) / EFI_PAGE_SIZE; > - efi_call_phys2(sys_table->boottime->free_pages, addr, size); > + efi_call_phys2(sys_table->boottime->free_pages, addr, nr_pages); > } > > static void find_bits(unsigned long mask, u8 *pos, u8 *size) Thanks Roy. I pulled this into my urgent queue, as it's obviously a bug and I don't fancy our chances if we ask the firmware to free more memory than it initially allocated. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists