linux-kernel - Re: [PATCH 1/4] ALSA: Added jack detection kcontrol support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130726185458.GX9858@sirena.org.uk>
Date:	Fri, 26 Jul 2013 19:54:58 +0100
From:	Mark Brown <broonie@...nel.org>
To:	"Felipe F. Tonello" <eu@...ipetonello.com>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	Takashi Iwai <tiwai@...e.de>,
	David Henningsson <david.henningsson@...onical.com>,
	Wang Xingchao <xingchao.wang@...ux.intel.com>,
	Jaroslav Kysela <perex@...ex.cz>
Subject: Re: [PATCH 1/4] ALSA: Added jack detection kcontrol support

On Fri, Jul 26, 2013 at 11:25:30AM -0700, Felipe F. Tonello wrote:

> +
> +	/* Update ALSA KControl interface */
> +	snd_kctl_jack_report((struct snd_card *)jack->kctl->private_data, jack->kctl, !!status);

This isn't ideal for multi-function jacks like headsets - it will report
a single boolean value for the jack regardless of what's plugged in
meaning userpace can't do things like figure out if a headset or
headphone is present.  It's probably OK for any realistic input button
since you're not going to get an input button without other things being
present.

What I'd expect to happen here is that for multi function jacks we
create a control per function if the controls are valid.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)