linux-kernel - Re: [PATCH 1/4] ALSA: Added jack detection kcontrol support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Jul 2013 12:10:27 -0700
From:	Felipe Tonello <eu@...ipetonello.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	Takashi Iwai <tiwai@...e.de>,
	David Henningsson <david.henningsson@...onical.com>,
	Wang Xingchao <xingchao.wang@...ux.intel.com>,
	Jaroslav Kysela <perex@...ex.cz>
Subject: Re: [PATCH 1/4] ALSA: Added jack detection kcontrol support

Mark,

On Fri, Jul 26, 2013 at 11:54 AM, Mark Brown <broonie@...nel.org> wrote:
> On Fri, Jul 26, 2013 at 11:25:30AM -0700, Felipe F. Tonello wrote:
>
>> +
>> +     /* Update ALSA KControl interface */
>> +     snd_kctl_jack_report((struct snd_card *)jack->kctl->private_data, jack->kctl, !!status);
>
> This isn't ideal for multi-function jacks like headsets - it will report
> a single boolean value for the jack regardless of what's plugged in
> meaning userpace can't do things like figure out if a headset or
> headphone is present.  It's probably OK for any realistic input button
> since you're not going to get an input button without other things being
> present.

The KControl for Jack is boolean anyway. You can check it with "amixer
contents". user-space can figure out based on the control name. At
least PulseAudio does that way.

>
> What I'd expect to happen here is that for multi function jacks we
> create a control per function if the controls are valid.

Do you mean based on snd_jack_types?

Felipe Tonello
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/