linux-kernel - Re: [PATCH 14/16] usb: musb: dsps: add MUSB_DEVCTL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51F2D427.7050106@linutronix.de>
Date:	Fri, 26 Jul 2013 21:55:19 +0200
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Bin Liu <binmlist@...il.com>
CC:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	balbi@...com, george.cherian@...com
Subject: Re: [PATCH 14/16] usb: musb: dsps: add MUSB_DEVCTL_SESSION back after
 removal

On 07/26/2013 08:29 PM, Bin Liu wrote:

Hi Bin,

>> [   97.570852] musb-hdrc musb-hdrc.1.auto: Poll devctl 19 (a_wait_bcon)
> I don't think you are testing with the 3.2 kernel you referred from
> the ti.com link you mentioned above.
> 3.2 kernel should have no '.auto' at the end of the device name.
> 
> If it is 3.8 or later, it seems the driver does something wrong,
> SESSION bit should not be cleared after the device is unplugged.

The bit is removed in otg_timer() because the phy gets into
OTG_STATE_A_WAIT_BCON.

Now, this is current HEAD + my stuff to get second port working. I
downloaded v3.2 and browsed as I was looking for the workaround, never
tested maybe I should…

On v3.8 from git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git I
don't get the second port to work. I see

[    1.989101] usb usb1: New USB device found, idVendor=1d6b, idProduct=0002
[    1.996361] usb usb1: New USB device strings: Mfr=3, Product=2,
SerialNumber=1
[    2.004060] usb usb1: Product: MUSB HDRC host driver
[    2.009363] usb usb1: Manufacturer: Linux 3.8.13+ musb-hcd
[    2.015183] usb usb1: SerialNumber: musb-hdrc.0.auto
[    2.033653] hub 1-0:1.0: USB hub found
[    2.037861] hub 1-0:1.0: 1 port detected

and nothing happens once I plug in the device.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/