linux-kernel - Re: [ 00/45] 3.0.88-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1374967837.3607.31.camel@deadeye.wl.decadent.org.uk>
Date:	Sun, 28 Jul 2013 00:30:37 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	linux@...ck-us.net
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, stable@...r.kernel.org
Subject: Re: [ 00/45] 3.0.88-stable review

On Sat, 2013-07-27 at 06:22 -0500, linux@...ck-us.net wrote:
> Quoting Greg Kroah-Hartman <gregkh@...uxfoundation.org>:
> 
> > This is the start of the stable review cycle for the 3.0.88 release.
> > There are 45 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sun Jul 28 20:54:53 UTC 2013.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > 	kernel.org/pub/linux/kernel/v3.0/stable-review/patch-3.0.88-rc1.gz
> > and the diffstat can be found below.
> >
> We have additional build failures.
> 
> Total builds: 54 Total build errors: 20
> 
> Link:  
> http://desktop.roeck-us.net/buildlogs/v3.0.87-45-g367423c.2013-07-27.03:09:16
> 
> Previously:
> Total builds: 54 Total build errors: 17
> 
> Additional failures are i386/allmodconfig, i386/allyesconfig and mips/malta.
> 
> I don't have time to track down the culprit tonight (I am still in  
> Down Under ;). I hope I can do it tomorrow.

I iterated through the 3.0 patch queue with i386/allmodconfig, and got
to:

Applying patch ifb-fix-rcu_sched-self-detected-stalls.patch
patching file drivers/net/ifb.c

Now at patch ifb-fix-rcu_sched-self-detected-stalls.patch
  CHK     include/linux/version.h
  CHK     include/generated/utsrelease.h
  CALL    scripts/checksyscalls.sh
  CHK     include/generated/compile.h
  VDSOSYM arch/x86/vdso/vdso32-int80-syms.lds
  VDSOSYM arch/x86/vdso/vdso32-sysenter-syms.lds
  VDSOSYM arch/x86/vdso/vdso32-syms.lds
  LD      arch/x86/vdso/built-in.o
  LD      arch/x86/built-in.o
  CC [M]  drivers/net/ifb.o
drivers/net/ifb.c: In function ‘ifb_init_module’:
drivers/net/ifb.c:257:3: error: implicit declaration of function ‘cond_resched’ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[2]: *** [drivers/net/ifb.o] Error 1
make[1]: *** [drivers/net] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2

I think this patch needs to add a '#include <linux/sched.h>', but that
header is being included indirectly in some other configurations (and in
mainline).

With that change, I can apply the remaining patches and compile
3.0.88-rc1 successfully.

Ben.

-- 
Ben Hutchings
All extremists should be taken out and shot.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)