linux-kernel - Re: [PATCH] drivers/rtc/rtc-palmas.c: support for backup battery charging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51F37785.9040604@nvidia.com>
Date:	Sat, 27 Jul 2013 13:02:21 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Stephen Warren <swarren@...dotorg.org>
CC:	Mark Brown <broonie@...nel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"rob@...dley.net" <rob@...dley.net>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"rtc-linux@...glegroups.com" <rtc-linux@...glegroups.com>,
	"gg@...mlogic.co.uk" <gg@...mlogic.co.uk>,
	"kishon@...com" <kishon@...com>,
	Stephen Warren <swarren@...dia.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <Mark.Rutland@....com>,
	Ian Campbell <ian.campbell@...rix.com>
Subject: Re: [PATCH] drivers/rtc/rtc-palmas.c: support for backup battery
 charging

On Friday 26 July 2013 10:12 PM, Stephen Warren wrote:
> On 07/26/2013 10:35 AM, Mark Brown wrote:
>> On Fri, Jul 26, 2013 at 09:40:15AM -0600, Stephen Warren wrote:
>>
>>> Given there's only 1 battery, I think "back-" is redundant in
>>> the property names. Since that shortens the names a bit, I'd
>>> suggest spelling everything out in full, perhaps:
>> Isn't there an integrated charger on the PMIC?  If there is then
>> it's useful to identify which is being talked about (even if it
>> should be relatively obvious).
> Oh yes, that's probably true. This is of course the binding for the
> RTC sub-module in the PMIC though.
>

I have currently Palma series 2 devices tps65913 and tps80036. TPS80036 
supports the charging of main battery. Both chip support the backup 
battery charging. Hence it is good to name the back-* here.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/