linux-kernel - Re: [PATCH 2/2] pinctrl: palmas: add pincontrol driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51F39F9F.5020607@nvidia.com>
Date:	Sat, 27 Jul 2013 15:53:27 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Mark Brown <broonie@...nel.org>
CC:	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"rob@...dley.net" <rob@...dley.net>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"lee.jones@...aro.org" <lee.jones@...aro.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"gg@...mlogic.co.uk" <gg@...mlogic.co.uk>,
	"kishon@...com" <kishon@...com>,
	Stephen Warren <swarren@...dia.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH 2/2] pinctrl: palmas: add pincontrol driver

On Friday 26 July 2013 10:11 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Fri, Jul 26, 2013 at 03:45:54PM +0530, Laxman Dewangan wrote:
>
>> +pins: gpio0_id, gpio1_vbus_det_led1_pwm1, gpio2_regen_led2_pwm2, gpio3_chrg_det,
>> +	gpio4_sysen1, gpio5_clk32kgaudio_usb_psel, gpio6_sysen2,
>> +	gpio7_msecure_pwrhold, gpio8_sim1rsti, gpio9_low_vbat,
>> +	gpio10_wireless_chrg1, gpio11_rcm, gpio12_sim2rsto, gpio13, gpio14,
>> +	gpio15_sim2rsti, vac, powergood_usb_psel, nreswarm, pwrdown,
>> +	gpadc_start, reset_in, nsleep, enable1, enable2, int.
> Would it not be easier to just name the GPIOs gpioN rather than using
> the full names with the possible functions?
>

I took the name approach as what we have on Tegra.
But I think I can put the name of the pins same as what we have in 
datasheet. So pin name will be exact same as what we have in datasheet. 
That will be easy to interpret.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/