linux-kernel - Re: [ 06/79] net: Swap ver and type in pppoe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1374981271.2476.0.camel@deadeye.wl.decadent.org.uk>
Date:	Sun, 28 Jul 2013 04:14:31 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [ 06/79] net: Swap ver and type in pppoe_hdr

On Sat, 2013-07-27 at 17:55 -0700, David Miller wrote:
> From: Ben Hutchings <ben@...adent.org.uk>
> Date: Sat, 27 Jul 2013 16:58:28 +0100
> 
> > I'm not so sure this is suitable for stable.  It doesn't seem to be
> > helpful to either userland or kernel code.
> > 
> > In the kernel, we were checking that ver == 1 and type == 1 thus this
> > wasn't hurting us.
> > 
> > If userland does anything more with these fields then it's probably
> > already working around the swapped fields.  It can work with both old
> > and new headers by doing:
> 
> It's up to you, I would rather have the corrected version propagated
> as soon as possible.  But that's just me.

Let's see what Greg thinks.

Ben.

-- 
Ben Hutchings
All extremists should be taken out and shot.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)