linux-kernel - Re: [PATCH V2] x86/PCI: MMCONFIG: cleanup and add address warning to pci_mmconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <77E02B89-C51A-4CCA-81ED-851F87A44EF5@gmail.com>
Date:	Sun, 28 Jul 2013 11:29:19 +0800
From:	ethan <ethan.kernel@...il.com>
To:	Mark D Rustad <mrustad@...il.com>
Cc:	"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"yinghai@...nel.org" <yinghai@...nel.org>,
	"jbarnes@...tuousgeek.org" <jbarnes@...tuousgeek.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jiang.liu@...wei.com" <jiang.liu@...wei.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"joe.jin@...cle.com" <joe.jin@...cle.com>,
	"ethan.zhao" <ethan.zhao@...cle.com>
Subject: Re: [PATCH V2] x86/PCI: MMCONFIG: cleanup and add address warning to pci_mmconfig_insert

thanks，got it ,you are right.


在 2013-7-28，11:09，Mark D Rustad <mrustad@...il.com> 写道：

> Another nit below:
> 
> On Jul 27, 2013, at 12:32 PM, ethan.kernel@...il.com wrote:
> 
>> Cleanup the -EINVAL return value handling and add warning message for invalid
>> start,end,addr parameters.
>> 
>> V2: Corrected code style and tested for Linux v 3.11-rc2
>> 
>> Signed-off-by: ethan.zhao <ethan.zhao@...cle.com>
>> ---
>> arch/x86/pci/mmconfig-shared.c |   12 ++++++------
>> 1 files changed, 6 insertions(+), 6 deletions(-)
>> 
>> diff --git a/arch/x86/pci/mmconfig-shared.c b/arch/x86/pci/mmconfig-shared.c
>> index 082e881..37f6c7f 100644
>> --- a/arch/x86/pci/mmconfig-shared.c
>> +++ b/arch/x86/pci/mmconfig-shared.c
>> @@ -700,8 +700,13 @@ int pci_mmconfig_insert(struct device *dev, u16 seg, u8 start, u8 end,
>>    if (!(pci_probe & PCI_PROBE_MMCONF) || pci_mmcfg_arch_init_failed)
>>        return -ENODEV;
>> 
>> -    if (start > end)
>> +    if (start > end || !addr) {
>> +        dev_warn(dev, FW_INFO
>> +            "Invalid address to add MMCONFIG"
>> +            "start %02x end %02x addr %pR\n",
> 
> As it is here, there will be no space between MMCONFIG and the word start. Better still, put the entire string on one line to aid those searching for the message. There is a general exception to the 80-column rule for user-visible messages such as this.
> 
> <snip>
> 
> -- 
> Mark Rustad, MRustad@...il.com
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/