linux-kernel - RE: [char-misc-next 2/3] mei: adding sysfs fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B1AE76B1B@HASMSX106.ger.corp.intel.com>
Date:	Sun, 28 Jul 2013 08:48:24 +0000
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	"arnd@...db.de" <arnd@...db.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Ovsyanikov, Natalia" <natalia.ovsyanikov@...el.com>
Subject: RE: [char-misc-next 2/3] mei: adding sysfs fw_status attribute

> On Wed, Jul 24, 2013 at 06:04:33PM +0000, Winkler, Tomas wrote:
> >
> >
> > > >
> > > > Just to make sure, is this what you're suggesting ?
> > > >
> > > > device->groups = mei_attr_groups
> > > > mei_misc_device.parent = device;
> > > > ret = misc_register(&mei_misc_device);
> > >
> > > Yes, that should work.  If not, please let me know, the code
> > > underwent some changes in 3.11-rc2.
> >
> > I don' t see the file being created.
> > Not sure if the  misc_register setup the parent sysfs as well.
> 
> Oops, wait, the parent is already registered, that's not going to work, you
> want to create the files for the device itself that you are creating, so set the -
> >groups field for that device.
> 
> sorry about that.

So is this okay to go as  is?
Thanks
Tomas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/