linux-kernel - Re: [PATCH v2 2/2] regulator: Add Dialog DA9063 voltage regulators support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130728125111.GW9858@sirena.org.uk>
Date:	Sun, 28 Jul 2013 13:51:11 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	Krystian Garbaciak <krystian.garbaciak@...semi.com>
Subject: Re: [PATCH v2 2/2] regulator: Add Dialog DA9063 voltage regulators
 support.

On Thu, Jul 25, 2013 at 07:39:03PM +0200, Philipp Zabel wrote:

>  - 1x power switch to switch on/off 32 KHz oscilator output (32K_OUT).

The driver looks good except this should be implemented using the clock
API not the regulator API - some drivers did this while we didn't have a
clock API but we do now and in any case the clock shouldn't appear as a
regulator in the DT bindings.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)