linux-kernel - Re: [PATCH v2] dma: pl330: Fix cyclic transfers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51F5340A.1090901@metafoo.de>
Date:	Sun, 28 Jul 2013 17:08:58 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Vinod Koul <vinod.koul@...el.com>
CC:	Dan Williams <djbw@...com>,
	Jassi Brar <jaswinder.singh@...aro.org>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] dma: pl330: Fix cyclic transfers

On 07/28/2013 03:45 PM, Vinod Koul wrote:
> On Tue, Jul 23, 2013 at 10:24:50AM +0200, Lars-Peter Clausen wrote:
>> Allocate a descriptor for each period of a cyclic transfer, not just the first.
>> Also since the callback needs to be called for each finished period make sure to
>> initialize the callback and callback_param fields of each descriptor in a cyclic
>> transfer.
>>
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
> Applied thanks
>

Thanks.

> Btw the switch moved should have return error for default case when direction is
> not slave, but thats not in context of this as you moved that code

Checking inside the loop makes the error handling more complicated since at 
that point the descriptor is already allocated and needs to be freed again. So 
we check this right at the beginning (Using is_slave_direction), so we'll never 
get to the loop if the direction is not OK. The default statement is mainly 
there to keep the compiler happy.

- Lars


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/