linux-kernel - Re: [PATCH v2 1/5] Staging: bcm: LeakyBucket: Fixed spacing/tabing issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1374975425.2075.16.camel@joe-AO722>
Date:	Sat, 27 Jul 2013 18:37:05 -0700
From:	Joe Perches <joe@...ches.com>
To:	Lilis Iskandar <veeableful@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	tulinizer@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] Staging: bcm: LeakyBucket: Fixed spacing/tabing
 issues

On Sun, 2013-07-28 at 03:34 +0800, Lilis Iskandar wrote:
> I don't understand what you mean by mentioning "git diff -w".
> Perhaps you can clarify it for me? Sorry :(

$ git diff --help | grep -w -A2 "\-w"
      -w, --ignore-all-space
           Ignore whitespace when comparing lines. This ignores differences even if one line has whitespace where the other line has none.

It makes sure you are doing only whitespace changes.
Any other changes show up as an actual diff.

You can also compile the changes and make sure
the .o files before and after don't change.

(Something like: assuming a clean tree)

$ cat compare_patch_obj_diffs.sh
#!/bin/bash

if [[ ! -e $1 || ! -f $1 ]]
then
    echo "$1 not found"
    exit $?
fi

grep -P "^\+\+\+" $1 |
while read file
do
    real_file=$(echo $file | cut -f2- -d'/')
    if [[ ${real_file:(-2)} == ".c" ]]
    then
	obj=${real_file%.c}.o
	make $obj
	mv $obj $obj.old
	patch -p1 < $1
	make $obj
	mv $obj $obj.new
	patch -p1 -R < $1
	size $obj.old $obj.new
	if [[ $2 == "y" ]]
	then
	    objdump -d $obj.old > $obj.old.dmp
	    objdump -d $obj.new > $obj.new.dmp
	    diff $obj.old.dmp $obj.new.dmp
	    rm -f $obj.old.dmp $obj.new.dmp
	fi
    fi
done


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/