linux-kernel - Re: [ 06/79] net: Swap ver and type in pppoe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130728182952.GC16560@kroah.com>
Date:	Sun, 28 Jul 2013 11:29:52 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	David Miller <davem@...emloft.net>
Cc:	ben@...adent.org.uk, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [ 06/79] net: Swap ver and type in pppoe_hdr

On Sat, Jul 27, 2013 at 09:39:43PM -0700, David Miller wrote:
> From: Greg KH <gregkh@...uxfoundation.org>
> Date: Sat, 27 Jul 2013 21:16:16 -0700
> 
> > On Sun, Jul 28, 2013 at 04:14:31AM +0100, Ben Hutchings wrote:
> >> On Sat, 2013-07-27 at 17:55 -0700, David Miller wrote:
> >> > From: Ben Hutchings <ben@...adent.org.uk>
> >> > Date: Sat, 27 Jul 2013 16:58:28 +0100
> >> > 
> >> > > I'm not so sure this is suitable for stable.  It doesn't seem to be
> >> > > helpful to either userland or kernel code.
> >> > > 
> >> > > In the kernel, we were checking that ver == 1 and type == 1 thus this
> >> > > wasn't hurting us.
> >> > > 
> >> > > If userland does anything more with these fields then it's probably
> >> > > already working around the swapped fields.  It can work with both old
> >> > > and new headers by doing:
> >> > 
> >> > It's up to you, I would rather have the corrected version propagated
> >> > as soon as possible.  But that's just me.
> >> 
> >> Let's see what Greg thinks.
> > 
> > I'm guessing that Linus's tree is also "wrong" here, correct?  If so,
> > the fix that goes into that tree should also go here as well.
> > 
> > Or am I confused?
> 
> Linus's tree has had this change for a full release.  It went into
> 3.10

But isn't this a review of the 3.10-stable series?  So what is the
probme?

> It's correcting a mistake that has been there since the header
> file even existed.

Ok, then I think this should be made, fixes are good to have, right?

So, unless someone objects, I'll just keep this as-is.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/