lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <51F5C504.6040504@huawei.com>
Date:	Mon, 29 Jul 2013 09:27:32 +0800
From:	Kefeng Wang <wangkefeng.wang@...wei.com>
To:	Jingoo Han <jg1.han@...sung.com>
CC:	"'Tomi Valkeinen'" <tomi.valkeinen@...com>,
	"'Jean-Christophe Plagniol-Villard'" <plagnioj@...osoft.com>,
	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<guohanjun@...wei.com>,
	"'Luis Henriques'" <luis.henriques@...onical.com>
Subject: Re: [PATCH] video: remove unused variable dev

On 07/29 8:52, Jingoo Han wrote:
> On Saturday, July 27, 2013 7:05 PM, Kefeng Wang wrote:
>>
>> Due to commit: e21d2170f [video: remove unnecessary platform_set_drvdata()],
>> variable dev is unused, so remove it.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
>> ---
>>  drivers/video/vga16fb.c | 1 -
>>  1 file changed, 1 deletion(-)
> 
> CC'ed Luis Henriques.
> 
> 
> Hi Kefeng Wang,
> 
> The same patch was submitted by Luis Henriques 2 weeks ago.
> Also, the patch was already applied by Tomi Valkeinen.
> 
> Best regards,
> Jingoo Han
> 

Thanks for your reply, I got it, so ignore it.

>>
>> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
>> index 830ded4..2827333 100644
>> --- a/drivers/video/vga16fb.c
>> +++ b/drivers/video/vga16fb.c
>> @@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
>>
>>  static void vga16fb_destroy(struct fb_info *info)
>>  {
>> -	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
>>  	iounmap(info->screen_base);
>>  	fb_dealloc_cmap(&info->cmap);
>>  	/* XXX unshare VGA regions */
>> --
>> 1.8.2.2
> 
> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ