linux-kernel - Re: [PATCH v1] backlight-lm3630-apply chip revision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <009701ce8bff$21cae730$6560b590$@samsung.com>
Date:	Mon, 29 Jul 2013 10:58:33 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	Daniel Jeong <gshark.jeong@...il.com>
Cc:	'Daniel Jeong' <daniel.jeong@...com>,
	'Andrew Morton' <akpm@...ux-foundation.org>,
	'Richard Purdie' <rpurdie@...ys.net>,
	linux-kernel@...r.kernel.org, Jingoo Han <jg1.han@...sung.com>
Subject: Re: [PATCH v1] backlight-lm3630-apply chip revision

On Friday, July 26, 2013 6:02 PM, Daniel Jeong wrote:
> Subject: [PATCH v1] backlight-lm3630-apply chip revision

Please don't use this subject, as I mentioned.
Also, this patch version is v2.

Thus, when you send the next version of this patch,
you should use the subject as below:

[PATCH v3] backlight: lm3630: apply chip revision

According to 'Documentation/SubmittingPatches',
15) The canonical patch format
The canonical patch subject line is:
    Subject: [PATCH 001/123] subsystem: summary phrase

> 
> The LM3630 chip was revised by TI and chip name was also changed to LM3630A.
> And register map, default values and intiial sequences are changed.

Looks good.


> lm3630_bl.c and .h files are deleted
> lm3630_bla.c and .h files are added

Fix the typo: lm3630_bla.c -> lm3630a_bl.c

The following is simpler.
lm3630_bl.{c,h} files are changed to lm3630a_bl.{c,h}.


> www.ti.com
>

Please, don't add meaningless commit message.
If you want to mention web address of your company,
please mention what it means as below:

The full datasheets are available from TI website:
http://www.ti.com/product/lm3630a


> Signed-off-by: daniel jeong <daniel.jeong@...com>

Please use upper case as below:
Signed-off-by: Daniel Jeong <daniel.jeong@...com>
                   ^^^     ^^^

In my opinion, you have to fix your .gitconfig file as below:

[user]
        email = daniel.jeong@...com
        name = Daniel Jeong

Daniel Jeong,
Please, read the './Documentation/SubmittingPatches', before you send
your patch.


Best regards,
Jingoo Han

> ---
>  drivers/video/backlight/Kconfig          |    6 +-
>  drivers/video/backlight/Makefile         |    2 +-
>  drivers/video/backlight/lm3630_bl.c      |  475 -----------------------------
>  drivers/video/backlight/lm3630a_bl.c     |  482 ++++++++++++++++++++++++++++++
>  include/linux/platform_data/lm3630_bl.h  |   57 ----
>  include/linux/platform_data/lm3630a_bl.h |   65 ++++
>  6 files changed, 551 insertions(+), 536 deletions(-)
>  delete mode 100644 drivers/video/backlight/lm3630_bl.c
>  create mode 100644 drivers/video/backlight/lm3630a_bl.c
>  delete mode 100644 include/linux/platform_data/lm3630_bl.h
>  create mode 100644 include/linux/platform_data/lm3630a_bl.h
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/