linux-kernel - Re: [PATCH v3 1/9] mm, hugetlb: move up the code which check availability of free huge page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Jul 2013 17:17:51 +0800
From:	Hillf Danton <dhillf@...il.com>
To:	Joonsoo Kim <iamjoonsoo.kim@....com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Rik van Riel <riel@...hat.com>, Mel Gorman <mgorman@...e.de>,
	Michal Hocko <mhocko@...e.cz>,
	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Hugh Dickins <hughd@...gle.com>,
	Davidlohr Bueso <davidlohr.bueso@...com>,
	David Gibson <david@...son.dropbear.id.au>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Joonsoo Kim <js1304@...il.com>,
	Wanpeng Li <liwanp@...ux.vnet.ibm.com>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
Subject: Re: [PATCH v3 1/9] mm, hugetlb: move up the code which check
 availability of free huge page

On Mon, Jul 29, 2013 at 1:28 PM, Joonsoo Kim <iamjoonsoo.kim@....com> wrote:
> In this time we are holding a hugetlb_lock, so hstate values can't
> be changed. If we don't have any usable free huge page in this time,
> we don't need to proceede the processing. So move this code up.
>
> Acked-by: Michal Hocko <mhocko@...e.cz>
> Reviewed-by: Wanpeng Li <liwanp@...ux.vnet.ibm.com>
> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@....com>
>
Acked-by: Hillf Danton <dhillf@...il.com>

> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index e2bfbf7..fc4988c 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -539,10 +539,6 @@ static struct page *dequeue_huge_page_vma(struct hstate *h,
>         struct zoneref *z;
>         unsigned int cpuset_mems_cookie;
>
> -retry_cpuset:
> -       cpuset_mems_cookie = get_mems_allowed();
> -       zonelist = huge_zonelist(vma, address,
> -                                       htlb_alloc_mask, &mpol, &nodemask);
>         /*
>          * A child process with MAP_PRIVATE mappings created by their parent
>          * have no page reserves. This check ensures that reservations are
> @@ -556,6 +552,11 @@ retry_cpuset:
>         if (avoid_reserve && h->free_huge_pages - h->resv_huge_pages == 0)
>                 goto err;
>
> +retry_cpuset:
> +       cpuset_mems_cookie = get_mems_allowed();
> +       zonelist = huge_zonelist(vma, address,
> +                                       htlb_alloc_mask, &mpol, &nodemask);
> +
>         for_each_zone_zonelist_nodemask(zone, z, zonelist,
>                                                 MAX_NR_ZONES - 1, nodemask) {
>                 if (cpuset_zone_allowed_softwall(zone, htlb_alloc_mask)) {
> @@ -574,7 +575,6 @@ retry_cpuset:
>         return page;
>
>  err:
> -       mpol_cond_put(mpol);
>         return NULL;
>  }
>
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/