[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130729111401.GA20951@mtj.dyndns.org>
Date: Mon, 29 Jul 2013 07:14:01 -0400
From: Tejun Heo <tj@...nel.org>
To: Shaohua Li <shli@...nel.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [patch]workqueue: copy attr with all fields.
Hello, Shaohua.
On Mon, Jul 29, 2013 at 02:24:12PM +0800, Shaohua Li wrote:
> copy_workqueue_attrs() forgets to copy no_numa field.
Explaining how that affects things and how the behavior changes
afterwards would be nice. As it currently stands, I don't know why
you're submitting this patch. Is this a bug fix? Just a consistency
update? Should it be marked with -stable?
Please put more effort into patch descriptions and also note that
->no_numa isn't a pool attribute as noted in the comment above struct
workqueue_attrs definition.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists