linux-kernel - Re: O_TMPFILE problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130729132234.GB9860@quack.suse.cz>
Date:	Mon, 29 Jul 2013 15:22:34 +0200
From:	Jan Kara <jack@...e.cz>
To:	Marco Stornelli <marco.stornelli@...il.com>
Cc:	Al Viro <viro@...IV.linux.org.uk>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Linux FS Devel <linux-fsdevel@...r.kernel.org>
Subject: Re: O_TMPFILE problem

On Sun 28-07-13 18:35:12, Marco Stornelli wrote:
> I'm doing a couple of test about O_TMPFILE on my fs. I can see that
> when the file is closed the blocks allocated are not freed. It
> happens because of i_mode, it isn't a regular file nor a directory
> nor a link. I added S_IFREG in my implementation of tmpfile callback
> when I have to call new_inode() and now it works, but am I missing
> something here?
  No, I think you are right. We need to add S_IFREG to the mode we pass to
->tmpfile().

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/